New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `BINARY_SLICE` and `STORE_SLICE` instructions. #94163

Closed

markshannon opened this issue Jun 23, 2022 · 0 comments

Labels

Member

markshannon commented Jun 23, 2022

We want this, because:

Specializing for indexing by int and by slice are different and should be treated differently
It avoids creating the temporary slice object.
Indexing by slice is syntactically distinct from indexing by object. The compiler can generate better code if it has different instructions.

For full discussion see faster-cpython/ideas#319

markshannon added the performance label

bedevere-bot mentioned this issue

GH-94163: Add BINARY_SLICE and STORE_SLICE instructions. #94168

Merged

markshannon added a commit that referenced this issue


          GH-94163: Add BINARY_SLICE and STORE_SLICE instructions. (GH-94168)

c0453a4

markshannon closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment