Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose libpath in venv.EnvBuilder.ensure_directories return value #94214

Closed
pradyunsg opened this issue Jun 24, 2022 · 3 comments · Fixed by #94221
Closed

Expose libpath in venv.EnvBuilder.ensure_directories return value #94214

pradyunsg opened this issue Jun 24, 2022 · 3 comments · Fixed by #94221
Labels
type-feature A feature request or enhancement

Comments

@pradyunsg
Copy link
Member

Feature or enhancement

venv.EnvBuilder.ensure_directories should set libpath as an attribute in the return value.

Pitch

Currently, the value is not exposed in any way via the venv API. This means that API users of venv (ahem... pip) need to recompute this information, coupling strongly to the implementation details of this module.

I noticed this as part of working on pip's build isolation logic, which I'm trying to port to venv.

Previous discussion

This hasn't been discussed extensively yet, but I've posted about this on https://discuss.python.org/t/16796/
@pradyunsg pradyunsg added the type-feature A feature request or enhancement label Jun 24, 2022
@pradyunsg pradyunsg changed the title Expose libpath in venv's context namespace Expose libpath in venv.EnvBuilder.ensure_directories return value Jun 24, 2022
@pfmoore pfmoore mentioned this issue Jun 24, 2022
Merged
@brettcannon
Copy link
Member

/cc @vsajip

@brettcannon
Copy link
Member

Tangent: @vsajip should we create a expert-venv label?

vsajip pushed a commit that referenced this issue Jun 26, 2022
@pfmoore
gh-94214: Add venv context.lib_path and document the context (GH-94221)
aedb519
@vsajip
Copy link
Member

vsajip commented Jun 26, 2022

Tangent: @vsajip should we create a expert-venv label?

Sure, though I don't know if stuff comes up often enough to merit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-94214: Add venv context.lib_path and document the context (GH-94221) pfmoore/cpython
3 participants
@brettcannon @vsajip @pradyunsg