Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST constructor can stack overflow when compiling some deep trees #95185

Closed
pablogsal opened this issue Jul 23, 2022 · 0 comments · Fixed by #95186
Closed

AST constructor can stack overflow when compiling some deep trees #95185

pablogsal opened this issue Jul 23, 2022 · 0 comments · Fixed by #95186

Comments

@pablogsal
Copy link
Member

pablogsal commented Jul 23, 2022 •
edited
Loading

This crashes CPython on most machines (use a release build):

python3 -c 'import ast; ast.parse("+0"*209644)'
@bedevere-bot bedevere-bot mentioned this issue Jul 23, 2022
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 23, 2022
@pablogsal
pythongh-95185: Check recursion depth in the AST constructor
dcdfb68 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Jul 24, 2022
@pablogsal @serhiy-storchaka
gh-95185: Check recursion depth in the AST constructor (#95186)
0047447 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 24, 2022
@pablogsal @miss-islington
pythongh-95185: Check recursion depth in the AST constructor (pythonG…
8794d47 
…H-95186)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 0047447)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 24, 2022
Merged
@bedevere-bot bedevere-bot mentioned this issue Jul 24, 2022
Closed
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 24, 2022
@pablogsal
[3.10] pythongh-95185: Check recursion depth in the AST constructor (p…
eabe3cf 
…ythonGH-95186)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>.
(cherry picked from commit 0047447)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ambv pushed a commit that referenced this issue Jul 26, 2022
@miss-islington @pablogsal
[3.11] gh-95185: Check recursion depth in the AST constructor (GH-95186…
86eb500 
…) (GH-95208)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 0047447)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@zzzeek zzzeek mentioned this issue Jun 7, 2023
Open
@cpcloud cpcloud mentioned this issue Jul 20, 2023
Closed
2 tasks
@dalf dalf mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-95185: Check recursion depth in the AST constructor pablogsal/cpython
1 participant
@pablogsal