Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml.dom.minidom:Attr.__init__ doesn't use localName variable. #96175

Closed
kkirsche opened this issue Aug 22, 2022 · 0 comments · Fixed by #96176
Closed

xml.dom.minidom:Attr.__init__ doesn't use localName variable. #96175

kkirsche opened this issue Aug 22, 2022 · 0 comments · Fixed by #96176
Labels
topic-XML type-bug An unexpected behavior, bug, or error

Comments

@kkirsche
Copy link
Contributor

Bug report

X-Ref: python/typeshed#8590 (comment)

Source:

cpython/Lib/xml/dom/minidom.py

Line 355 in 18b1782

def __init__(self, qName, namespaceURI=EMPTY_NAMESPACE, localName=None,

This initialization function takes a value but does not use the value. This issue is to address that.

Your environment

N/A
@kkirsche kkirsche added the type-bug An unexpected behavior, bug, or error label Aug 22, 2022
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2022
Merged
@kkirsche kkirsche mentioned this issue Aug 22, 2022
Merged
JelleZijlstra added a commit that referenced this issue Aug 23, 2022
@kkirsche @JelleZijlstra
gh-96175: add missing self._localName assignment in `xml.dom.minidom.…
58f6953 
…Attr` (#96176)

X-Ref: python/typeshed#8590 (comment)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 23, 2022
@kkirsche @miss-islington
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
75e16ef 
…nidom.Attr` (pythonGH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
This was referenced Aug 23, 2022
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 23, 2022
@kkirsche @miss-islington
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
b3d9308 
…nidom.Attr` (pythonGH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
miss-islington added a commit that referenced this issue Aug 23, 2022
@miss-islington @kkirsche
gh-96175: add missing self._localName assignment in `xml.dom.minidom.…
e783a23 
…Attr` (GH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
miss-islington added a commit that referenced this issue Aug 23, 2022
@miss-islington @kkirsche
gh-96175: add missing self._localName assignment in `xml.dom.minidom.…
d7eea0f 
…Attr` (GH-96176)

X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58f6953)

Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
mdboom pushed a commit to mdboom/cpython that referenced this issue Aug 24, 2022
@kkirsche @JelleZijlstra @mdboom
pythongh-96175: add missing self._localName assignment in `xml.dom.mi…
77c8ccc 
…nidom.Attr` (python#96176)

X-Ref: python/typeshed#8590 (comment)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-XML type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-96175: add missing self._localName assignment in xml.dom.minidom.Attr kkirsche/cpython
2 participants
@kkirsche @AlexWaygood