Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Improve coverage of unicode_find and unicode_rfind #98648

Merged
merged 1 commit into from
Oct 25, 2022
Merged

gh-94808: Improve coverage of unicode_find and unicode_rfind #98648

merged 1 commit into from
Oct 25, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 25, 2022 •
edited by bedevere-bot

These lines in any_find_slice were not covered:

Снимок экрана 2022-10-25 в 14 10 18

Now, it is: find covers direction > 0 and rfind covers direction < 0.

This is also related to #98229
But, extra tests won't hurt in any case.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 25, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 25, 2022
@JelleZijlstra JelleZijlstra merged commit b1783bc into python:main Oct 25, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@sobolevn @miss-islington
pythongh-94808: Improve coverage of unicode_find and unicode_rfind (
db31a28 
pythonGH-98648)

(cherry picked from commit b1783bc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-98683 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@sobolevn @miss-islington
pythongh-94808: Improve coverage of unicode_find and unicode_rfind (
98766fc 
pythonGH-98648)

(cherry picked from commit b1783bc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-98684 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 25, 2022
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-94808: Improve coverage of unicode_find and unicode_rfind (GH-…
cb323a8 
…98648)

(cherry picked from commit b1783bc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-94808: Improve coverage of unicode_find and unicode_rfind (GH-…
18b788c 
…98648)

(cherry picked from commit b1783bc)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Cammiec91 Cammiec91 Cammiec91 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @Cammiec91