Skip to content

gh-94808: Improve coverage of unicode_find and unicode_rfind #98648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

gh-94808: Improve coverage of unicode_find and unicode_rfind #98648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Lib/test/test_unicode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,20 @@ def test_find(self):
self.checkequalnofix(9, 'abcdefghiabc', 'find', 'abc', 1)
self.checkequalnofix(-1, 'abcdefghiabc', 'find', 'def', 4)

# test utf-8 non-ascii char
self.checkequal(0, 'тест', 'find', 'т')
self.checkequal(3, 'тест', 'find', 'т', 1)
self.checkequal(-1, 'тест', 'find', 'т', 1, 3)
self.checkequal(-1, 'тест', 'find', 'e') # english `e`
# test utf-8 non-ascii slice
self.checkequal(1, 'тест тест', 'find', 'ес')
self.checkequal(1, 'тест тест', 'find', 'ес', 1)
self.checkequal(1, 'тест тест', 'find', 'ес', 1, 3)
self.checkequal(6, 'тест тест', 'find', 'ес', 2)
self.checkequal(-1, 'тест тест', 'find', 'ес', 6, 7)
self.checkequal(-1, 'тест тест', 'find', 'ес', 7)
self.checkequal(-1, 'тест тест', 'find', 'ec') # english `ec`

self.assertRaises(TypeError, 'hello'.find)
self.assertRaises(TypeError, 'hello'.find, 42)
# test mixed kinds
Expand Down Expand Up @@ -291,6 +305,19 @@ def test_rfind(self):
self.checkequalnofix(9, 'abcdefghiabc', 'rfind', 'abc')
self.checkequalnofix(12, 'abcdefghiabc', 'rfind', '')
self.checkequalnofix(12, 'abcdefghiabc', 'rfind', '')
# test utf-8 non-ascii char
self.checkequal(1, 'тест', 'rfind', 'е')
self.checkequal(1, 'тест', 'rfind', 'е', 1)
self.checkequal(-1, 'тест', 'rfind', 'е', 2)
self.checkequal(-1, 'тест', 'rfind', 'e') # english `e`
# test utf-8 non-ascii slice
self.checkequal(6, 'тест тест', 'rfind', 'ес')
self.checkequal(6, 'тест тест', 'rfind', 'ес', 1)
self.checkequal(1, 'тест тест', 'rfind', 'ес', 1, 3)
self.checkequal(6, 'тест тест', 'rfind', 'ес', 2)
self.checkequal(-1, 'тест тест', 'rfind', 'ес', 6, 7)
self.checkequal(-1, 'тест тест', 'rfind', 'ес', 7)
self.checkequal(-1, 'тест тест', 'rfind', 'ec') # english `ec`
# test mixed kinds
self.checkequal(0, 'a' + '\u0102' * 100, 'rfind', 'a')
self.checkequal(0, 'a' + '\U00100304' * 100, 'rfind', 'a')
Expand Down