Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100077: make test_code.test_invalid_bytecode more robust and maintainable #100078

Merged
merged 1 commit into from
Dec 7, 2022
Merged

gh-100077: make test_code.test_invalid_bytecode more robust and maintainable #100078

merged 1 commit into from
Dec 7, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 7, 2022 •
edited by bedevere-bot

  • construct the invalid bytecode via mutation of a valid function, rather than from scratch.
  • assert that 238 is indeed an invalid opcode

Fixes #100077.

@bedevere-bot bedevere-bot mentioned this pull request Dec 7, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 7, 2022
@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 07310c6
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6390ab97e149310008e16719

gvanrossum
gvanrossum approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Discussed offline.)

@iritkatriel iritkatriel merged commit f3e97c9 into python:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_code.test_invalid_bytecode is a bit cryptic and flaky
3 participants
@iritkatriel @gvanrossum @bedevere-bot