Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35039: remove unused clock() objects add pep8 corrections #10044

Closed
wants to merge 2 commits into from

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Oct 22, 2018

bpo-35039: remove unused clock() objects and add pep8 correction

This is based on #10033 But add some pep8 corrections

https://bugs.python.org/issue35039

@ned-deily
Copy link
Member

ned-deily commented Oct 22, 2018

@eamanu Thanks for your contribution. If you submit a PR and then need to change something before it is merged, just push new commits to the existing PR, don't open a new one, please. That just creates confusion. If this #10044 is supposed to supersede #10033, please close it. Thanks!

@ned-deily
Copy link
Member

Oh, sorry, I missed that #10033 was created by @srinivasreddy. Perhaps the two of you can settle on one PR.

@srinivasreddy
Copy link
Contributor

srinivasreddy commented Oct 23, 2018

@eamanu Could you please raise an another ticket for pep8 changes and use it?.

@eamanu
Copy link
Contributor Author

eamanu commented Oct 23, 2018

@ned-deily ohh sorry for the confusion! Now, I will work with @srinivasreddy

@eamanu
Copy link
Contributor Author

eamanu commented Oct 23, 2018

@srinivasreddy Ok, so I will Close this PR and I will create a new PR for pep8 solution. Right?

@srinivasreddy
Copy link
Contributor

srinivasreddy commented Oct 23, 2018

Yes, please. You do not need to close this PR. You can remove my commit and do the rest.

@eamanu
Copy link
Contributor Author

eamanu commented Oct 23, 2018

Ok! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants