Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-72249: Include the module name in the repr of partial object #101910

Merged
merged 18 commits into from Feb 25, 2024

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Feb 14, 2023

Co-authored-by: Anilyka Barry

@furkanonder furkanonder changed the title Include the module name in the repr of functool GH-72249: Include the module name in the repr of functool Feb 14, 2023
@furkanonder furkanonder changed the title GH-72249: Include the module name in the repr of functool GH-72249: Include the module name in the repr of partial object Feb 14, 2023
@rhettinger rhettinger removed their request for review February 15, 2023 03:33
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 15, 2023
@furkanonder furkanonder changed the title GH-72249: Include the module name in the repr of partial object gh-72249: Include the module name in the repr of partial object Aug 6, 2023
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Lib/functools.py Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 8f5be78 into python:main Feb 25, 2024
36 checks passed
@Vgr255
Copy link
Contributor

Vgr255 commented Feb 25, 2024

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

@furkanonder
Copy link
Contributor Author

@serhiy-storchaka Thank you so much for your feedback, patience (sometimes explaining my mistakes over and over again), and time. I'd want to thank you again for providing me with the opportunity to better understand the CPython code-base.

@furkanonder
Copy link
Contributor Author

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

You are welcome!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants