Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35110: Fix unintentional spaces around hyphens and dashes. #10231

Merged
merged 1 commit into from Oct 31, 2018
Merged

bpo-35110: Fix unintentional spaces around hyphens and dashes. #10231

merged 1 commit into from Oct 31, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 30, 2018 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner October 30, 2018 09:44
@tirkarthi
Copy link
Member

Is there a sphinx related warning where this can be checked? @serhiy-storchaka, do you have any regex that was used to find these scenarios that could perhaps be added to make patchcheck given the similar previous fixes?

@serhiy-storchaka serhiy-storchaka merged commit 3f819ca into python:master Oct 31, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-hyphens-spaces branch October 31, 2018 00:26
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3f819ca138db6945ee4271bf13e42db9f9b3b1e4 3.7

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3f819ca138db6945ee4271bf13e42db9f9b3b1e4 3.6

@bedevere-bot
Copy link

GH-10253 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-10254 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 31, 2018
@serhiy-storchaka
[3.7] bpo-35110: Fix unintentional spaces around hyphens and dashes. (p…
8423475 
…ythonGH-10231).

(cherry picked from commit 3f819ca)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 31, 2018
@serhiy-storchaka
[3.6] bpo-35110: Fix unintentional spaces around hyphens and dashes. (p…
72ae2d0 
…ythonGH-10231).

(cherry picked from commit 3f819ca)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
Member Author

I used many regexes: ^ *--+[^- ], [^-*' ]-+ +$, [^-*' ]-+ +\|, etc. They usually found many false cases, so every case should be considered individually. In general, it is impossible to write automatic check, because the validity depends on the context.

serhiy-storchaka added a commit that referenced this pull request Oct 31, 2018
@serhiy-storchaka
[3.7] bpo-35110: Fix unintentional spaces around hyphens and dashes. (G…
b183750 
…H-10231). (GH-10253)

(cherry picked from commit 3f819ca)
serhiy-storchaka added a commit that referenced this pull request Oct 31, 2018
@serhiy-storchaka
[3.6] bpo-35110: Fix unintentional spaces around hyphens and dashes. (G…
1e8c185 
…H-10231). (GH-10254)

(cherry picked from commit 3f819ca)
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serhiy-storchaka @tirkarthi @miss-islington @bedevere-bot @JulienPalard @the-knights-who-say-ni