Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102797: Add more code snippets for exec_tests and eval_tests #102798

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-102797: Add more code snippets for exec_tests and eval_tests #102798

wants to merge 7 commits into from
+180 −7

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Mar 17, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 17, 2023
Open
terryjreedy
terryjreedy reviewed Mar 18, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For first review, exec test look ok. Aside from 1 addition, I think fewer comments needed. The breadth covered by a comment seems uneven (not your fault).

Lib/test/test_ast.py Outdated Show resolved Hide resolved
Lib/test/test_ast.py Show resolved Hide resolved
Lib/test/test_ast.py Outdated Show resolved Hide resolved
Lib/test/test_ast.py Outdated Show resolved Hide resolved
Lib/test/test_ast.py Outdated Show resolved Hide resolved
@hugovk hugovk changed the title gh-102797: Add more code snipets for exec_tests and eval_tests gh-102797: Add more code snippets for exec_tests and eval_tests Mar 18, 2023
Eclips4
Eclips4 commented Mar 20, 2023
View reviewed changes
Lib/test/test_ast.py
# IfExp
"foo() if x else bar()",
# JoinedStr and FormattedValue
"f'{a}'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since FormattedValue cannot be used without a JoinedStr, so separate this snippets makes no sense.

@Eclips4
Copy link
Member Author

Eclips4 commented Mar 20, 2023 •
edited

However, single_tests look kinda strange. It says: These are compiled through "single" because of ovelarp with "eval", it just tests what can't be tested with "eval". I think, there should be more tests, and this comment is pointless.

But I don't know, should it be a separate PR?

vstinner
vstinner approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. More tests are usually a good thing.

@vstinner
Copy link
Member

vstinner commented Jun 7, 2024

Ah, sadly there is now a merge conflict, I cannot merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TODO in test_ast.py
5 participants
@Eclips4 @vstinner @terryjreedy @carljm @bedevere-bot