Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100227: Make the Global Interned Dict Safe for Isolated Interpreters #102858

Closed
wants to merge 9 commits into from
Closed

gh-100227: Make the Global Interned Dict Safe for Isolated Interpreters #102858

wants to merge 9 commits into from

Commits on Mar 20, 2023

  1. Initialize the interned dict in _PyUnicode_InitGlobalObjects().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    9420a1c View commit details
    Browse the repository at this point in the history

  2. Add some TODO comments.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    cca77b9 View commit details
    Browse the repository at this point in the history

  3. Factor out store_interned().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    fa3974f View commit details
    Browse the repository at this point in the history

  4. Store a thread state to use just for interned strings.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    eadd48a View commit details
    Browse the repository at this point in the history

  5. Always use the main interpreter when possibly resizing the interned d… 

    …ict.
    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5d6e1b9 View commit details
    Browse the repository at this point in the history

  6. Make interned strings immortal.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    16ed5e0 View commit details
    Browse the repository at this point in the history

  7. Temporarily skip immortalizing.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d36f119 View commit details
    Browse the repository at this point in the history

  8. Add the mutex for the interned dict.

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6d5f129 View commit details
    Browse the repository at this point in the history

  9. Lock around store_interned().

    @ericsnowcurrently
    ericsnowcurrently committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    b634920 View commit details
    Browse the repository at this point in the history