Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-63284: Add support for TLS-PSK (pre-shared key) to the ssl module #103181

Merged
merged 22 commits into from Nov 27, 2023
Merged

gh-63284: Add support for TLS-PSK (pre-shared key) to the ssl module #103181

merged 22 commits into from Nov 27, 2023

Commits on Apr 3, 2023

  1. pythongh-63284: Add support for TLS-PSK (pre-shared key) to the ssl m… 

    …odule
    @grantramsay
    grantramsay committed Apr 3, 2023
    Copy the full SHA
    9d0f6dc View commit details
    Browse the repository at this point in the history

  2. Fix TLS-PSK for TLS 1.3 

    SSL_CTX_set_session_id_context() is a server-side only operation.
Using this on the client-side is causing authentication errors
    @grantramsay
    grantramsay committed Apr 3, 2023
    Copy the full SHA
    cfddf7b View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Merge branch 'main' into fix-issue-63284

    @arhadthedev
    arhadthedev committed May 14, 2023
    Copy the full SHA
    603eeef View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Decode TLS-PSK identities as UTF-8 rather than ASCII 

    RFC4279 states these are UTF-8.
Add unit test using non-ASCII chars
    @grantramsay
    grantramsay committed Jun 4, 2023
    Copy the full SHA
    18302e3 View commit details
    Browse the repository at this point in the history

  2. Change TLS-PSK version added from 3.12 to 3.13 

    The PR has missed the 3.12 merge window
    @grantramsay
    grantramsay committed Jun 4, 2023
    Copy the full SHA
    2efc876 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. ReSTify NEWS.

    @gpshead
    gpshead committed Jun 5, 2023
    Copy the full SHA
    a56784c View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Merge branch 'main' into fix-issue-63284

    @gpshead
    gpshead committed Jul 14, 2023
    Copy the full SHA
    7a1963d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Set python exceptions raised during C callbacks as unraisable

    @grantramsay
    grantramsay committed Jul 15, 2023
    Copy the full SHA
    6f4100c View commit details
    Browse the repository at this point in the history

  2. Add NULL check for defensive coding

    @grantramsay
    grantramsay committed Jul 15, 2023
    Copy the full SHA
    e4a97ec View commit details
    Browse the repository at this point in the history

  3. Get single value using PyBytes_AsStringAndSize 

    There is no need to use PyArg_Parse in this simple case
    @grantramsay
    grantramsay committed Jul 15, 2023
    Copy the full SHA
    3d75982 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Do not raise a decode exception if remote side sends invalid UTF-8 du… 

    …ring TLS-PSK negotiation

In this case the remote side is breaking the standard (rfc4279).
Just drop the connection
    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    539ed1f View commit details
    Browse the repository at this point in the history

  2. Free TLS-PSK callbacks when SSL context is deallocated

    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    4634fc3 View commit details
    Browse the repository at this point in the history

  3. Use Py_XINCREF and Py_XDECREF for tidier NULL checking

    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    d21c322 View commit details
    Browse the repository at this point in the history

  4. Check return value of SSL_CTX_use_psk_identity_hint

    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    03fac4d View commit details
    Browse the repository at this point in the history

  5. Update TLS-PSK documentation 

    Add length limits of identity and hint parameters.
Add how to reject a connection
    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    3db3921 View commit details
    Browse the repository at this point in the history

  6. Regenerate news entry to update the timestamp

    @grantramsay
    grantramsay committed Jul 16, 2023
    Copy the full SHA
    a75f3a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Merge branch 'main' into fix-issue-63284

    @gpshead
    gpshead committed Nov 26, 2023
    Copy the full SHA
    851a1e5 View commit details
    Browse the repository at this point in the history

  2. Update example key strings in the doc.

    @gpshead
    gpshead committed Nov 26, 2023
    Copy the full SHA
    4c68974 View commit details
    Browse the repository at this point in the history

  3. Update TLS-PSK documentation 

    Demonstrate usage in a safer way that rejects
unknown connection attempts
    @grantramsay
    grantramsay committed Nov 26, 2023
    Copy the full SHA
    0fb8a3e View commit details
    Browse the repository at this point in the history

  4. Regenerate news entry to update the timestamp

    @grantramsay
    grantramsay committed Nov 26, 2023
    Copy the full SHA
    7788589 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Code defensively around z# vs NULL and 0 length.

    @gpshead
    gpshead committed Nov 27, 2023
    Copy the full SHA
    11735b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix-issue-63284' of https://github.com/grantramsay/cpython 

     into fix-issue-63284
    @gpshead
    gpshead committed Nov 27, 2023
    Copy the full SHA
    ad8b249 View commit details
    Browse the repository at this point in the history