Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103357: Add logging.Formater defaults support to logging.config fileConfig and dictConfig #103359

Merged
merged 4 commits into from Apr 12, 2023

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Apr 8, 2023

Added the support for the defaults parameter, tests suite runs well.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 8, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Apr 8, 2023
@arhadthedev
Copy link
Member

@vsajip (as a logging module expert)

@vsajip vsajip merged commit 8f54302 into python:main Apr 12, 2023
17 checks passed
@vsajip vsajip added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Apr 12, 2023
@miss-islington
Copy link
Contributor

Thanks @bharel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @bharel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @bharel and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.11

@miss-islington
Copy link
Contributor

Sorry @bharel and @vsajip, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.10

@vsajip vsajip removed the needs backport to 3.10 only security fixes label Apr 12, 2023
@vsajip
Copy link
Member

vsajip commented Apr 12, 2023

Actually 3.10 is now security-fixes only.

@bharel bharel deleted the add-defaults-logging-config branch April 13, 2023 03:57
@bharel
Copy link
Contributor Author

bharel commented Apr 13, 2023

@vsajip Thanks for the merge 😄
Why are we adding to 3.11? Is this technically a bug fix or a new feature? I'm guessing you took it as a bug fix, but I saw it as a feature. Keep in mind that the Python version I've set in the docs reference 3.12, and must be changed to 3.11.3/4 if so.

@vsajip
Copy link
Member

vsajip commented Apr 13, 2023

You're right, it is a new feature - I wasn't thinking clearly. Let's leave it and not backport.

@arhadthedev arhadthedev removed the needs backport to 3.11 only security fixes label Apr 13, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants