Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103088: Fix test error message #103500

Merged
merged 1 commit into from Apr 13, 2023
Merged

gh-103088: Fix test error message #103500

merged 1 commit into from Apr 13, 2023

Conversation

Zabolekar
Copy link
Contributor

@Zabolekar Zabolekar commented Apr 13, 2023

@arhadthedev
Copy link
Member

Triggering the buildbots to get logs with the new message.

@arhadthedev arhadthedev added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 13, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @arhadthedev for commit bf3c063 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 13, 2023
@arhadthedev
Copy link
Member

The tests are done:

======================================================================
FAIL: test_activate_shell_script_has_no_dos_newlines (test.test_venv.BasicTest.test_activate_shell_script_has_no_dos_newlines)
Test that the `activate` shell script contains no CR LF.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\pull_request.bolen-windows10\build\Lib\test\test_venv.py", line 628, in test_activate_shell_script_has_no_dos_newlines
    self.assertFalse(line.endswith(b'\r\n'), error_message)
AssertionError: True is not false : CR LF found in line 1
----------------------------------------------------------------------

@arhadthedev
Copy link
Member

According to https://git-scm.com/docs/gitattributes#_text, we need to check if core.autocrlf is set in git config on Windows because it overrides .gitattributes.

@zooba
Copy link
Member

zooba commented Apr 13, 2023

It only overrides the value of core.eol being used as the default, which is not what is happening here. We've explicitly set the line ending for the file, we just need anyone who's checked it out in the past to delete it and check it out again (tested on my own Windows machine, which has core.autocrlf set).

If we can't find a way to force the buildbots to do a clean checkout, instead of reusing their existing one, then we probably need to ping all the owners to log in and do it manually.

@zooba
Copy link
Member

zooba commented Apr 13, 2023

The buildbot results look good (the expected failure), so merging this. Buildbot discussion back to #103088 please.

@zooba zooba merged commit 4307fea into python:main Apr 13, 2023
92 of 99 checks passed
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants