Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-69695: Update PyImport_ImportModule description #103836

Merged
merged 4 commits into from
Feb 2, 2024
Merged

GH-69695: Update PyImport_ImportModule description #103836

merged 4 commits into from
Feb 2, 2024

Conversation

patenaud
Copy link
Contributor

import.rst file updated

gh-69695: PyImport_ImportModule description updated

@AA-Turner AA-Turner mentioned this pull request Apr 25, 2023
Closed
@AA-Turner AA-Turner changed the title doc: update import.rst PyImport_ImportModule description #69695 GH-69695: Update PyImport_ImportModule description Apr 25, 2023
@arhadthedev arhadthedev added skip news docs Documentation in the Doc dir awaiting review labels Apr 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 25, 2023
Closed
AA-Turner
AA-Turner reviewed Apr 27, 2023
View reviewed changes
Doc/c-api/import.rst Outdated Show resolved Hide resolved
brettcannon
brettcannon previously requested changes May 12, 2023
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lines are too long; I suspect Adam's line wrapping suggestions should fix the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

encukou and others added 2 commits January 24, 2024 15:13
@encukou @AA-Turner
Apply suggestions from review
de518b6 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@encukou
Merge branch 'main' into fix_import_docs
e1b2261
@encukou
Copy link
Member

encukou commented Jan 29, 2024

I have made the requested changes; please review again.

(I wonder if this works if I'm not the PR author.)

@AlexWaygood
Copy link
Member

I have made the requested changes; please review again.

(I wonder if this works if I'm not the PR author.)

It doesn't work for anybody right now:

@encukou encukou dismissed brettcannon’s stale review February 1, 2024 12:52

The lines are short now.

@encukou encukou merged commit 9872855 into python:main Feb 2, 2024
24 of 25 checks passed
@miss-islington-app
Copy link

Thanks @patenaud for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2024
@patenaud @AlexWaygood
@AA-Turner @miss-islington
pythonGH-69695: Update PyImport_ImportModule description (pythonG…
368514e 
…H-103836)

(cherry picked from commit 9872855)

Co-authored-by: patenaud <33957588+patenaud@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2024

GH-114924 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 2, 2024
@encukou encukou added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 2, 2024
@miss-islington-app
Copy link

Thanks @patenaud for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @patenaud for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2024
@patenaud @AlexWaygood
@AA-Turner @miss-islington
pythonGH-69695: Update PyImport_ImportModule description (pythonG…
33f2ab5 
…H-103836)

(cherry picked from commit 9872855)

Co-authored-by: patenaud <33957588+patenaud@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2024
@patenaud @AlexWaygood
@AA-Turner @miss-islington
pythonGH-69695: Update PyImport_ImportModule description (pythonG…
eb78100 
…H-103836)

(cherry picked from commit 9872855)

Co-authored-by: patenaud <33957588+patenaud@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2024

GH-114925 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 2, 2024
encukou pushed a commit that referenced this pull request Feb 5, 2024
@miss-islington @patenaud
@AlexWaygood @AA-Turner
[3.11] GH-69695: Update PyImport_ImportModule description (GH-103836
b3f0108 
) (GH-114924)

GH-69695: Update ``PyImport_ImportModule`` description (GH-103836)

(cherry picked from commit 9872855)

Co-authored-by: patenaud <33957588+patenaud@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Feb 5, 2024
@miss-islington @patenaud
@AlexWaygood @AA-Turner
[3.12] GH-69695: Update PyImport_ImportModule description (GH-103836
d334122 
) GH-114925)

GH-69695: Update ``PyImport_ImportModule`` description (GH-103836)

(cherry picked from commit 9872855)

Co-authored-by: patenaud <33957588+patenaud@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@patenaud @AlexWaygood
@AA-Turner @aisk
pythonGH-69695: Update PyImport_ImportModule description (pythonG…
c7e607c 
…H-103836)


Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@patenaud @AlexWaygood
@AA-Turner @fsc-eriker
pythonGH-69695: Update PyImport_ImportModule description (pythonG…
632fce1 
…H-103836)


Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@brettcannon brettcannon brettcannon left review comments

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news topic-importlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@patenaud @bedevere-bot @encukou @AlexWaygood @brettcannon @AA-Turner @arhadthedev