Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104886: Remove deprecated configparser.LegacyInterpolation #104887

Merged
merged 5 commits into from May 26, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 24, 2023

Closes #104886.

Remove the undocumented configparser.LegacyInterpolation class.

It was deprecated in the docstring since Python 3.2, deprecated with a warning since Python 3.11, and scheduled for removal in 3.13.


馃摎 Documentation preview 馃摎: https://cpython-previews--104887.org.readthedocs.build/

@hugovk hugovk added stdlib Python modules in the Lib dir 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just had a minor suggestion.

@ambv: Was it you who changed this interpolation method?

Wow, it took a while to completely finish the transition :-)

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@ambv
Copy link
Contributor

ambv commented May 25, 2023

Yeah, I originally never intended to remove the old one but here we are!

@vstinner
Copy link
Member

Yeah, I originally never intended to remove the old one but here we are!

Well, you first wrote:

class BrokenInterpolation(Interpolation):
    """Deprecated interpolation as implemented in the classic ConfigParser.

It was marked as "deprecated" in the docstring ;-)

Maybe it's time to break the API again, and add a pending deprecated VeryBadlyBrokenInterpolation class :-D

hugovk and others added 2 commits May 25, 2023 19:28
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk enabled auto-merge (squash) May 26, 2023 05:43
@hugovk hugovk merged commit 3f9c60f into python:main May 26, 2023
20 of 21 checks passed
@hugovk hugovk deleted the rm-configparser.LegacyInterpolation branch May 26, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated configparser.LegacyInterpolation class
4 participants