Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104924: Fix read()able in http.client log messages #104926

Merged
merged 2 commits into from
May 26, 2023
Merged

gh-104924: Fix read()able in http.client log messages #104926

merged 2 commits into from
May 26, 2023

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented May 25, 2023 •
edited by bedevere-bot

@arhadthedev arhadthedev added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels May 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
Closed
gaogaotiantian
gaogaotiantian requested changes May 25, 2023
View reviewed changes
Copy link
Member

@gaogaotiantian gaogaotiantian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sendIng is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).

Lib/http/client.py Outdated Show resolved Hide resolved
Lib/http/client.py Outdated Show resolved Hide resolved
@arhadthedev @gaogaotiantian
sendIng -> reading
644722d 
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@Eclips4 Eclips4 mentioned this pull request May 25, 2023
Closed
@LyingDalai
Copy link

I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from.

corona10
corona10 approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 6c81d75 into python:main May 26, 2023
20 checks passed
@miss-islington
Copy link
Contributor

Thanks @arhadthedev for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@arhadthedev @miss-islington
pythongh-104924: Fix read()able in http.client log messages (pyth…
8ec8ba9 
…ongh-104926)

(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot
Copy link

GH-104970 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 26, 2023
@bedevere-bot
Copy link

GH-104971 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@arhadthedev @miss-islington
pythongh-104924: Fix read()able in http.client log messages (pyth…
0906563 
…ongh-104926)

(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@arhadthedev arhadthedev deleted the http-read-able branch May 26, 2023 11:53
corona10 pushed a commit that referenced this pull request May 26, 2023
@miss-islington @arhadthedev
[3.11] gh-104924: Fix read()able in http.client log messages (gh-…
f585ed1 
…104926) (gh-104971)

gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
corona10 pushed a commit that referenced this pull request May 26, 2023
@miss-islington @arhadthedev
[3.12] gh-104924: Fix read()able in http.client log messages (gh-…
83bdfa4 
…104926) (gh-104970)

gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@arhadthedev @LyingDalai @miss-islington @bedevere-bot @corona10 @gaogaotiantian