Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docs as part of the MSI test #104929

Merged
merged 3 commits into from
May 25, 2023
Merged

Build docs as part of the MSI test #104929

merged 3 commits into from
May 25, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented May 25, 2023

No description provided.

@zooba zooba added tests Tests in the Lib/test dir skip issue skip news labels May 25, 2023
@zooba zooba mentioned this pull request May 25, 2023
Merged
@zooba zooba enabled auto-merge (squash) May 25, 2023 11:50
@zooba zooba disabled auto-merge May 25, 2023 12:02
@zooba zooba requested a review from a team as a code owner May 25, 2023 12:02
@zooba zooba merged commit 569b2b8 into python:main May 25, 2023
19 of 21 checks passed
@zooba zooba added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels May 25, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@zooba zooba deleted the msitest branch May 25, 2023 15:17
@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.11

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 569b2b8d612354062b8679d2d3f44f7ee03e66c2 3.12

@zooba zooba added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels May 25, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
@zooba @miss-islington
Improves the Windows MSI test run on PR (pythonGH-104929)
ca15e6a 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-104934 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 25, 2023
zooba added a commit that referenced this pull request May 25, 2023
@miss-islington @zooba
Improves the Windows MSI test run on PR (GH-104929)
d176f78 
Correctly set the exit code when builds fail
Also build docs as part of the test
(cherry picked from commit 569b2b8)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-104940 is a backport of this pull request to the 3.10 branch.

zooba added a commit that referenced this pull request May 25, 2023
@zooba
[3.10] Improves the Windows MSI test run on PR (GH-104929)
f22ddbf 
Correctly set the exit code when builds fail
Also build docs as part of the test
zware
zware reviewed May 25, 2023
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the fact :)

@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware left review comments

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

@zooba zooba

Labels
needs backport to 3.11 only security fixes skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @bedevere-bot @zware