Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104955: Fix __release_buffer__ signature #104956

Merged
merged 2 commits into from
May 26, 2023
Merged

gh-104955: Fix __release_buffer__ signature #104956

merged 2 commits into from
May 26, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 26, 2023 •
edited by bedevere-bot

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
Closed
@JelleZijlstra @kumaraditya303
Update Misc/NEWS.d/next/Core and Builtins/2023-05-25-21-40-39.gh-issu…
3c5d2cf 
…e-104955.LZx7jf.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@JelleZijlstra JelleZijlstra merged commit 6e1eccd into python:main May 26, 2023
21 checks passed
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the releasebufsig branch May 26, 2023 12:44
@bedevere-bot
Copy link

GH-104973 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@JelleZijlstra @kumaraditya303 @miss-islington
pythongh-104955: Fix __release_buffer__ signature (pythonGH-104956)
5a9c46e 
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 26, 2023
JelleZijlstra added a commit that referenced this pull request May 26, 2023
@miss-islington @JelleZijlstra @kumaraditya303
[3.12] gh-104955: Fix __release_buffer__ signature (GH-104956) (#104973)
3158b4d 
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature for __release_buffer__ is incorrect
4 participants
@JelleZijlstra @miss-islington @bedevere-bot @kumaraditya303