GH-101588: Deprecate pickle/copy/deepcopy support in itertools #104965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yhg1s
approved these changes
May 26, 2023
Lib/test/test_itertools.py
Outdated
| import warnings | ||
|
|
||
| def pickle_deprecated(testfunc): | ||
| """ Run the test twice. On the first pass, verify that a |
There was a problem hiding this comment.
Is it worth it to run them a third time, with DeprecationWarnings promoted to errors? That usually ends up exercising paths that rarely get considered, but it'd probably be more in pickle than in itertools.
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2023
…ythonGH-104965) (cherry picked from commit 402ee5a) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
|
GH-104997 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thomas, the C code deprecation and the related tests were created in a way that should be easy to review and easy to turned-off if need arises.
📚 Documentation preview 📚: https://cpython-previews--104965.org.readthedocs.build/