Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105017: Fix including additional NL token when using CRLF #105022

Merged
merged 4 commits into from
May 27, 2023
Merged

gh-105017: Fix including additional NL token when using CRLF #105022

merged 4 commits into from
May 27, 2023

Conversation

mgmacias95
Copy link
Contributor

@mgmacias95 mgmacias95 commented May 27, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request May 27, 2023
Closed
pablogsal
pablogsal approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work ✨

@pablogsal pablogsal added needs backport to 3.12 bug and security fixes and removed awaiting merge labels May 27, 2023
@pablogsal pablogsal enabled auto-merge (squash) May 27, 2023 16:26
@pablogsal pablogsal merged commit 86d8f48 into python:main May 27, 2023
23 of 25 checks passed
@miss-islington
Copy link
Contributor

Thanks @mgmacias95 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105023 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@mgmacias95 @pablogsal @miss-islington
pythongh-105017: Fix including additional NL token when using CRLF (p…
1c7e37d 
…ythonGH-105022)

(cherry picked from commit 86d8f48)

Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 27, 2023
pablogsal added a commit that referenced this pull request May 27, 2023
@miss-islington @mgmacias95 @pablogsal
[3.12] gh-105017: Fix including additional NL token when using CRLF (G…
2b176bc 
…H-105022) (#105023)

Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgmacias95 @miss-islington @bedevere-bot @pablogsal