Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103646: Remove --include-pip-user from default APPX package build #105064

Merged
merged 1 commit into from
May 29, 2023
Merged

gh-103646: Remove --include-pip-user from default APPX package build #105064

merged 1 commit into from
May 29, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented May 29, 2023 •
edited by bedevere-bot

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.12 bug and security fixes labels May 29, 2023
@zooba zooba requested a review from a team as a code owner May 29, 2023 16:10
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Open
pfmoore
pfmoore reviewed May 29, 2023
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to completely remove the "pip-user" option? As far as I can see, it's only used in get_pip_layout in PC\layout\support\pip.py. Having the option present but never used seems like a potential source of confusion.

@zooba
Copy link
Member Author

zooba commented May 29, 2023 •
edited

Deprecating and removing a command line option is a bigger change than just changing a preset, since the presets are deliberately unspecified.

I doubt anyone is actually using it, but I see no reason to find out by simply removing it. There are potentially useful scenarios that might be using it where they wouldn't be covered by the unwritable-Lib fallback (I know of one such scenario, though I don't know that they're actively using this option).

@zooba zooba merged commit 6da7015 into python:main May 29, 2023
24 of 25 checks passed
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2023
@zooba @miss-islington
pythongh-103646: Remove --include-pip-user from default APPX package …
d93d7e5 
…build (pythonGH-105064)

(cherry picked from commit 6da7015)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-105065 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 29, 2023
@zooba
Copy link
Member Author

zooba commented May 29, 2023

Want to make sure this is in for 3.12.0b2 tomorrow, but we can look at cleaning up unused options later.

@zooba zooba deleted the gh-103646 branch May 29, 2023 16:58
zooba added a commit that referenced this pull request May 29, 2023
@miss-islington @zooba
gh-103646: Remove --include-pip-user from default APPX package build (G…
56722ef 
…H-105064)

(cherry picked from commit 6da7015)

Co-authored-by: Steve Dower <steve.dower@python.org>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore pfmoore left review comments

Assignees
No one assigned
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @bedevere-bot @pfmoore