Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105077: Fix test_tkinter refleak checking #105078

Merged
merged 1 commit into from
May 30, 2023
Merged

gh-105077: Fix test_tkinter refleak checking #105078

merged 1 commit into from
May 30, 2023

Conversation

zware
Copy link
Member

@zware zware commented May 30, 2023 •
edited by bedevere-bot

Use specific symbols from test.support to avoid having support
overwritten by test_tkinter's own support submodule.

@zware
pythongh-105077: Fix test_tkinter refleak checking
b807168 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
@zware zware added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir skip news topic-tkinter labels May 30, 2023
@zware zware self-assigned this May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Closed
@zware zware enabled auto-merge (squash) May 30, 2023 03:27
@zware zware added the needs backport to 3.12 bug and security fixes label May 30, 2023
@zware zware merged commit 5454db4 into python:main May 30, 2023
25 of 27 checks passed
@zware zware deleted the fix_test_tkinter_refleak_checking branch May 30, 2023 03:53
@miss-islington
Copy link
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@zware @miss-islington
pythongh-105077: Fix test_tkinter refleak checking (pythonGH-105078)
55edff7 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-bot
Copy link

GH-105079 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 30, 2023
zware pushed a commit that referenced this pull request May 30, 2023
@miss-islington
[3.12] gh-105077: Fix test_tkinter refleak checking (GH-105078) (GH-1…
7f04a15 
…05079)

Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@zware zware

Labels
skip news tests Tests in the Lib/test dir topic-tkinter type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zware @miss-islington @bedevere-bot @JelleZijlstra