Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms #105092

Merged
merged 1 commit into from May 30, 2023
Merged

gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms #105092

merged 1 commit into from May 30, 2023

Conversation

encukou
Copy link
Member

@encukou encukou commented May 30, 2023 •
edited by bedevere-bot

@encukou encukou added skip issue skip news build The build process and cross-build labels May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Closed
@encukou encukou merged commit 0656d23 into python:main May 30, 2023
22 of 24 checks passed
@encukou encukou deleted the unixy-unixy branch May 30, 2023 15:46
@AlexWaygood
Copy link
Member

This should probably be backported to 3.12, right?

carljm added a commit to carljm/cpython that referenced this pull request May 30, 2023
@carljm
Merge branch 'main' into superbadgetattro
24e1159 
* main:
  CI: Temporarily skip paths with spaces to avoid error (python#105110)
  pythongh-105071: add missing versionadded directive (python#105097)
  pythongh-80064: Fix is_valid_wide_char() return type (python#105099)
  Small speedup for dataclass __eq__ and __repr__ (python#104904)
  pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)
  pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
@encukou encukou added the needs backport to 3.12 bug and security fixes label May 31, 2023
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2023
@encukou @miss-islington
pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on ot…
56ec4a7 
…her platforms (pythonGH-105092)

(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot
Copy link

GH-105133 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 31, 2023
encukou added a commit that referenced this pull request May 31, 2023
@miss-islington @encukou
[3.12] gh-105091: stable_abi.py: Remove "Unixy" check from --all on o…
4729100 
…ther platforms (GH-105092) (GH-105133)

gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (GH-105092)
(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@encukou
Copy link
Member Author

encukou commented May 31, 2023

It won't hurt, but I hope we can avoid poking the stable ABI in 3.12 :)

@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build The build process and cross-build skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@encukou @AlexWaygood @miss-islington @bedevere-bot