Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1. #105129

Closed
wants to merge 3 commits into from

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented May 31, 2023

@ned-deily ned-deily added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels May 31, 2023
@ned-deily ned-deily changed the title Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@ned-deily ned-deily changed the title gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@ned-deily ned-deily requested review from gpshead and ambv May 31, 2023 19:48
@gpshead
Copy link
Member

gpshead commented May 31, 2023

There are PCbuild/ and .azure-pipelines/ references that also need updating (see my draft #105174 which I was just basing off of what I blindly did for the previous update in #101727). But lets go forward with your PR here just adding those bits. I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

@gpshead
Copy link
Member

gpshead commented May 31, 2023

some windows versions may need to wait on someone uploading an openssl-bin-1.1.1u artifact somewhere? based on #101727 comments @zooba did that last time.

@gpshead gpshead requested a review from zooba May 31, 2023 22:22
@zooba
Copy link
Member

zooba commented May 31, 2023

I've posted the binaries for Windows. They are codesigned, so have to be done by someone with release team access.

I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

I thought there was an open issue/PR to replace this file? As we should have access to OpenSSL's copies of this data. Guess it isn't merged yet...

@gpshead
Copy link
Member

gpshead commented Jun 1, 2023

I updated my PR #105174 to have the additional bits that this touched plus a tweak to the _ssl_data .h file regeneration. If CI and buildbots are happy with it, I'll merge mine and generate the backport PRs.

@gpshead gpshead marked this pull request as draft June 1, 2023 03:32
@ned-deily
Copy link
Member Author

Closed in favor of #105174

@ned-deily ned-deily closed this Jun 1, 2023
@gpshead
Copy link
Member

gpshead commented Jun 1, 2023

woo, thanks Ned! (we were both considering this, when I created my PR I hadn't yet looked to see if someone else had taken this on. No worries from my end about the duplicate work collision, it's good to have eyeballs on the issue).

@ned-deily ned-deily deleted the gh-103142-multissltests branch June 6, 2023 18:49
@ambv ambv removed needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants