Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that error messages are better with PEP 701 #105150

Merged
merged 6 commits into from
May 31, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 31, 2023

@pablogsal
Copy link
Member Author

CC: @mgmacias95

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
@mgmacias95
Copy link
Contributor

For some reason the code is not highlighted in the preview docs:
image

Is this expected? The other syntax error blocks have the code higlighted:
image

@pablogsal
Copy link
Member Author

pablogsal commented May 31, 2023

Seems that the lexer in sphinx has problems with the $ in the example. I will replace this by another kind of syntax error:

Screenshot 2023-05-31 at 21 43 14

@pablogsal pablogsal merged commit 60cfc6d into python:main May 31, 2023
18 of 19 checks passed
@pablogsal pablogsal deleted the better_701 branch May 31, 2023 21:01
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2023
(cherry picked from commit 60cfc6d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
@bedevere-bot
Copy link

GH-105169 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 31, 2023
hugovk pushed a commit that referenced this pull request Jun 5, 2023
#105169)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants