Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc #105190

Merged
merged 5 commits into from
Jun 2, 2023
Merged

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc #105190

merged 5 commits into from
Jun 2, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 1, 2023 •
edited by github-actions bot

PyErr_PrintEx now populates also sys.last_exc, and the old variables are still populated by deprecated.

📚 Documentation preview 📚: https://cpython-previews--105190.org.readthedocs.build/

@iritkatriel iritkatriel added docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes labels Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Closed
@iritkatriel iritkatriel changed the title gh-102778: update documentation of PyErr_PrintEx regarding sys.last_exc gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc Jun 1, 2023
terryjreedy
terryjreedy requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with change.

Doc/library/traceback.rst Show resolved Hide resolved
Doc/c-api/exceptions.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel @terryjreedy
Apply suggestions from code review
00a6936 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@iritkatriel
Copy link
Member Author

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@iritkatriel iritkatriel merged commit 0dafc78 into python:main Jun 2, 2023
20 of 23 checks passed
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
@iritkatriel @miss-islington
pythongh-102778: update documentation of PyErr_PrintEx and traceback.…
de2b136 
…print_last() regarding sys.last_exc (pythonGH-105190)

(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-105246 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 2, 2023
iritkatriel added a commit that referenced this pull request Jun 2, 2023
@miss-islington @iritkatriel
[3.12] gh-102778: update documentation of PyErr_PrintEx and traceback…
00fe618 
….print_last() regarding sys.last_exc (GH-105190) (#105246)

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc (GH-105190)
(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@iritkatriel iritkatriel deleted the PyErr_Print-doc branch July 25, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iritkatriel @bedevere-bot @miss-islington @terryjreedy