Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-102404, GH-100956: Document how to do a WASI build #105251

Merged
merged 14 commits into from
Jun 2, 2023
Merged

GH-102404, GH-100956: Document how to do a WASI build #105251

merged 14 commits into from
Jun 2, 2023

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Jun 2, 2023 •
edited by bedevere-bot

Also includes a reference shell script to implements what is documented.

@brettcannon brettcannon self-assigned this Jun 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 2, 2023
Closed
@brettcannon brettcannon requested a review from mdboom June 2, 2023 19:13
mdboom
mdboom reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- it's nice to see a minimal example of what needs to happen in that shell script.

Tools/wasm/README.md Show resolved Hide resolved
Tools/wasm/build_wasi.sh Show resolved Hide resolved
Tools/wasm/README.md Outdated Show resolved Hide resolved
Tools/wasm/README.md Outdated Show resolved Hide resolved
Tools/wasm/README.md Outdated Show resolved Hide resolved
Tools/wasm/build_wasi.sh Show resolved Hide resolved
@brettcannon brettcannon mentioned this pull request Jun 2, 2023
Closed
@brettcannon brettcannon merged commit 70dc2fb into python:main Jun 2, 2023
20 of 21 checks passed
@brettcannon brettcannon deleted the document-wasi-build branch June 2, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom left review comments

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettcannon @mdboom @bedevere-bot