Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False #105281

Merged
merged 5 commits into from
Jun 5, 2023
Merged

gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False #105281

merged 5 commits into from
Jun 5, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 4, 2023 •
edited by bedevere-bot
Loading

@AlexWaygood AlexWaygood added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir topic-typing needs backport to 3.12 bug and security fixes labels Jun 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 4, 2023
Closed
@AlexWaygood
Copy link
Member Author

I've run the third-party test workflow we have at typing_extensions on a version of this PR, and it doesn't cause any regressions.

This was referenced Jun 4, 2023
Merged
Merged
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Lib/test/test_typing.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Lib/typing.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Lib/typing.py Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 5, 2023 13:35
@AlexWaygood AlexWaygood merged commit 08756db into python:main Jun 5, 2023
16 checks passed
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the fix-gc-protocol-bug branch June 5, 2023 14:11
@bedevere-bot
Copy link

GH-105318 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@AlexWaygood @miss-islington
pythongh-105280: Ensure isinstance([], collections.abc.Mapping) alw…
c004e38 
…ays evaluates to `False` (pythonGH-105281)

(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 5, 2023
AlexWaygood added a commit that referenced this pull request Jun 5, 2023
@miss-islington @AlexWaygood
[3.12] gh-105280: Ensure isinstance([], collections.abc.Mapping) al…
2031238 
…ways evaluates to `False` (GH-105281) (#105318)

gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` (GH-105281)
(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra