[3.11] gh-103171: Revert undocumented behaviour change for runtime-checkable protocols decorated with @final
#105445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime-checkable protocols decorated with `@final`
AlexWaygood
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
JelleZijlstra
approved these changes
Jun 7, 2023
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Jun 7, 2023
…ls decorated with `@final` Forward-port of the tests that were added to the 3.11 branch in python#105445
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2023
…ls dec orated with `@final` (pythonGH-105473) Forward-port of the tests that were added to the 3.11 branch in pythonGH-105445 (cherry picked from commit f5df347) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the behaviour of
@finalruntime-checkable protocols on Python 3.11 in line with the behaviour of these protocols on Python 3.10 and Python 3.12@finaland@runtime_checkablein 3.11 #103171