-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-105331: Fix asyncio.sleep() bug #105641
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f2008da
gh-105331: Fix asyncio.sleep() bug
weijay0804 cb1492f
📜🤖 Added by blurb_it.
blurb-it[bot] ca806d9
run make patchcheck to fix Azure Pipelines PR problem
weijay0804 588bbbd
gh-105331: move import math to the toplevel
weijay0804 1c17886
gh-105331: Improve the content description of the error message
weijay0804 9bd7ced
gh-105331: Improve description to more detailed
weijay0804 cc03137
gh-105331: Fix the indentation change
weijay0804 4a08061
gh-105331: Add test for asyncio.sleep() delay is nan
weijay0804 11b9d7e
gh-105331: Move check delay is nan section after delay <= 0 section
weijay0804 7c3f3eb
gh-105331: Add description for versionchanged
weijay0804 730ee4e
Update Misc/NEWS.d/next/Core and Builtins/2023-06-11-09-14-30.gh-issu…
weijay0804 49c55c6
minor tweaks
kumaraditya303 c1712ad
refer to `nan` not `math.nan`
kumaraditya303 5c840c4
fix news
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core and Builtins/2023-06-11-09-14-30.gh-issue-105331.nlZvoW.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add ``asyncio.sleep()`` error handel. When call ``asyncio.sleep(float('nan'))``, it should be raise ValueError. | ||
weijay0804 marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this check after
delay <= 0
check to not slow down the common case ofsleep(0)
.