Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-105840: Fix assertion failures when specializing calls with too many __defaults__ #105847

Merged
merged 3 commits into from Jun 16, 2023
Merged

GH-105840: Fix assertion failures when specializing calls with too many __defaults__ #105847

merged 3 commits into from Jun 16, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jun 16, 2023 •
edited by bedevere-bot

@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 16, 2023
@brandtbucher brandtbucher self-assigned this Jun 16, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 16, 2023
Closed
@brandtbucher brandtbucher merged commit 2beab5b into python:main Jun 16, 2023
26 checks passed
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105863 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2023
@brandtbucher @miss-islington
pythonGH-105840: Fix assertion failures when specializing calls with …
db50093 
…too many __defaults__ (pythonGH-105847)

(cherry picked from commit 2beab5b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2023
@brandtbucher @miss-islington
pythonGH-105840: Fix assertion failures when specializing calls with …
7a089fb 
…too many __defaults__ (pythonGH-105847)

(cherry picked from commit 2beab5b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot
Copy link

GH-105864 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 16, 2023
brandtbucher added a commit that referenced this pull request Jun 16, 2023
@miss-islington @brandtbucher
[3.12] GH-105840: Fix assertion failures when specializing calls with…
560adb0 
… too many __defaults__ (GH-105863)

GH-105840: Fix assertion failures when specializing calls with too many __defaults__ (GH-105847)
(cherry picked from commit 2beab5b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
brandtbucher added a commit that referenced this pull request Jun 16, 2023
@miss-islington @brandtbucher
[3.11] GH-105840: Fix assertion failures when specializing calls with…
2944a6c 
… too many __defaults__ (GH-105864)

GH-105840: Fix assertion failures when specializing calls with too many __defaults__ (GH-105847)
(cherry picked from commit 2beab5b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@brandtbucher @gvanrossum
pythonGH-105840: Fix assertion failures when specializing calls with …
24f31e0 
…too many __defaults__ (pythonGH-105847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brandtbucher @miss-islington @bedevere-bot @JelleZijlstra