gh-106310 - document the __signature__ attribute #106311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's an existing version added note for 3.3 for the entire Signature subsection in the inspect docs, so there is no need to add one for this specifically. |
ncoghlan
added
needs backport to 3.11
|
Thanks @Gouvernathor for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 20, 2023
Document the __signature__ attribute (cherry picked from commit b07f232) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 20, 2023
Document the __signature__ attribute (cherry picked from commit b07f232) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-111145 is a backport of this pull request to the 3.12 branch. |
|
GH-111146 is a backport of this pull request to the 3.11 branch. |
|
Thanks ! 🎉 |
hugovk
pushed a commit
that referenced
this pull request
Oct 23, 2023
hugovk
pushed a commit
that referenced
this pull request
Oct 23, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Document the __signature__ attribute Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
See #115937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspect.unwrap entry already makes clear that wrappers over a signatured function are recognized.
Maybe it would be worth adding a
.. versionadded::entry, I'm not sure, but in that case I don't know what version I should target.📚 Documentation preview 📚: https://cpython-previews--106311.org.readthedocs.build/