Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Add more type hints to Argument Clinic DSLParser() #106354

Merged
merged 19 commits into from
Jul 3, 2023
Merged

gh-104050: Add more type hints to Argument Clinic DSLParser() #106354

merged 19 commits into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. pythongh-104050: Add more type hints to Argument Clinic DSLParser() 

    Add basic annotations to state_modulename_name()
    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    15d4b03 View commit details
    Browse the repository at this point in the history

  2. Fix shadowing post partition

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4744bd9 View commit details
    Browse the repository at this point in the history

  3. Tighten up parse_converter() return annotation

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    7df949b View commit details
    Browse the repository at this point in the history

  4. Loosen up state_parameters_start()

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    7667704 View commit details
    Browse the repository at this point in the history

  5. ast.expr is not str

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0480ed2 View commit details
    Browse the repository at this point in the history

  6. Annotate Parameter 'kind' param as inspect._ParameterKind

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ec7c1d8 View commit details
    Browse the repository at this point in the history

  7. Annotate DSLParser 'function' attr as 'Function | None'

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ec38c62 View commit details
    Browse the repository at this point in the history

  8. Make sure Parameter() gets name as str

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b1bd72a View commit details
    Browse the repository at this point in the history

  9. Function param self_converter is CConverter or None

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    3f1a0c0 View commit details
    Browse the repository at this point in the history

  10. Make sure str is used as key in parameter dict

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d694f04 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into clinic/even-more-typing

    @AlexWaygood
    AlexWaygood committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f116de8 View commit details
    Browse the repository at this point in the history

  12. Annotation for c_basename

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    e587ba4 View commit details
    Browse the repository at this point in the history

  13. More accurate type for self.self_converter

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    cd5d675 View commit details
    Browse the repository at this point in the history

  14. Address review: fix return_converter type

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f25dd99 View commit details
    Browse the repository at this point in the history

  15. from __future__ imports must occur at the beginning of the file!

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dcd5d32 View commit details
    Browse the repository at this point in the history

  16. Pull in main

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4c3844e View commit details
    Browse the repository at this point in the history

  17. Pull in main

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    89ba85a View commit details
    Browse the repository at this point in the history

  18. Wrap touched lines at 79 chars

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    140bafc View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review

    @erlend-aasland
    erlend-aasland committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4a7edf9 View commit details
    Browse the repository at this point in the history