Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106602: Add __copy__ and __deepcopy__ in Enum #106666

Merged
merged 7 commits into from
Jul 12, 2023
Merged

gh-106602: Add __copy__ and __deepcopy__ in Enum #106666

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70da0fd
gh-106602: Add __copy__ and __deepcopy__ in Enum
Agent-Hellboy Jul 12, 2023
02a5839
gh-106602: Add __copy__ and __deepcopy__ in Enum
Agent-Hellboy Jul 12, 2023
7f8a78d
Merge branch 'fix-issue-106602' of https://github.com/Agent-Hellboy/c…
Agent-Hellboy Jul 12, 2023
bfd02d6
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 12, 2023
326e630
Update Lib/test/test_enum.py
Agent-Hellboy Jul 12, 2023
8015aef
Resolve comment
Agent-Hellboy Jul 12, 2023
a5905d4
Update Lib/enum.py
ethanfurman Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,6 +1226,12 @@ def __reduce_ex__(self, proto):
# on class lookup; on instance lookup it either executes a provided function
# or raises an AttributeError.

def __deepcopy__(self,memo):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these two methods above the enum.property comment.

return self

def __copy__(self):
return self

ethanfurman marked this conversation as resolved.
Show resolved Hide resolved
@property
def name(self):
"""The name of the Enum member."""
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,9 +804,17 @@ def test_copy(self):
TE = self.MainEnum
copied = copy.copy(TE)
self.assertEqual(copied, TE)
self.assertIs(copied, TE)
deep = copy.deepcopy(TE)
self.assertEqual(deep, TE)
self.assertIs(copied, TE)
Agent-Hellboy marked this conversation as resolved.
Show resolved Hide resolved

def test_copy_member(self):
TE = self.MainEnum
copied = copy.copy(TE.first)
self.assertIs(copied, TE.first)
deep = copy.deepcopy(TE.first)
self.assertIs(deep, TE.first)

class _FlagTests:

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-07-12-04-58-45.gh-issue-106602.dGCcXe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add __copy__ and __deepcopy__ in :mod:`enum`