gh-104683: Argument clinic: use an enum to describe the different kinds of functions #106721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
AlexWaygood
commented
Jul 13, 2023
Comment on lines
+2460
to
+2465
| INVALID: Final = FunctionKind.INVALID | ||
| CALLABLE: Final = FunctionKind.CALLABLE | ||
| STATIC_METHOD: Final = FunctionKind.STATIC_METHOD | ||
| CLASS_METHOD: Final = FunctionKind.CLASS_METHOD | ||
| METHOD_INIT: Final = FunctionKind.METHOD_INIT | ||
| METHOD_NEW: Final = FunctionKind.METHOD_NEW |
There was a problem hiding this comment.
It would be nice if we could use the @enum.global_enum decorator on the FunctionKind class; that would make this bit less verbose. Unfortunately, it was added in Python 3.11, and we still support Python 3.10 in argument clinic. Mypy also doesn't support global_enum yet.
|
LGTM! Let's wait for #106368 to land. Also, this is a very nice improvement. Thanks! |
erlend-aasland
approved these changes
Jul 13, 2023
kgdiem
pushed a commit
to kgdiem/cpython
that referenced
this pull request
Jul 14, 2023
…nt kinds of functions (python#106721) Argument clinic: use an enum to describe the different kinds of functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools/clinic/#104683