Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106751: selectors: optimize EpollSelector.select() #106754

Merged
merged 7 commits into from Jul 18, 2023
Merged

gh-106751: selectors: optimize EpollSelector.select() #106754

merged 7 commits into from Jul 18, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Jul 14, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Closed
@bdraco bdraco changed the title gh-106751: Optimize EpollSelector performance gh-106751: Reduce EpollSelector overhead by moving code outside of the loop and avoiding a call to max() Jul 14, 2023
@bdraco bdraco marked this pull request as ready for review July 14, 2023 21:12
eendebakpt
eendebakpt reviewed Jul 14, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
@bdraco @eendebakpt
Update Lib/selectors.py
83d46be 
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
bdraco
bdraco commented Jul 14, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
bdraco
bdraco commented Jul 14, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
eendebakpt
eendebakpt approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@eendebakpt eendebakpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. It took a bit of time for me to understand how the operation of and on integers is used in the event processing. The readability of that part of the code is not great. But it is not worse than before, so I am fine with the changes as is.

methane
methane reviewed Jul 18, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
@methane methane changed the title gh-106751: Reduce EpollSelector overhead by moving code outside of the loop and avoiding a call to max() gh-106751: selectors: optimize EpollSelector.select() Jul 18, 2023
@bdraco @methane
Update Lib/selectors.py
ee3b057 
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@methane
Copy link
Member

methane commented Jul 18, 2023

Would you do some micro benchmark?

@methane
Copy link
Member

methane commented Jul 18, 2023

I missed your benchmark result in the issue.

@methane methane enabled auto-merge (squash) July 18, 2023 09:36
@methane methane merged commit aecf6ac into python:main Jul 18, 2023
22 checks passed
@bdraco
Copy link
Contributor Author

bdraco commented Jul 18, 2023

Thanks!

corona10 added a commit to corona10/cpython that referenced this pull request Jul 18, 2023
@corona10
pythongh-106754: Optimize kqueue selector of the event loop
499d777
@eendebakpt eendebakpt mentioned this pull request Jul 18, 2023
Merged
@bdraco bdraco deleted the epoll branch July 21, 2023 21:55
bdraco added a commit to bdraco/docker-base that referenced this pull request Jul 22, 2023
@bdraco
Backport selector performance improvements from cpython
3ee9501 
python/cpython#106665
python/cpython#106555
python/cpython#106754
python/cpython#106528
@bdraco bdraco mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane left review comments

@eendebakpt eendebakpt eendebakpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdraco @methane @eendebakpt @bedevere-bot