Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-86493: Fix possible leaks in modules initialization: _curses_panel, _decimal, posix, xxsubtype #106767

Merged
merged 1 commit into from Jul 18, 2023
Merged

gh-86493: Fix possible leaks in modules initialization: _curses_panel, _decimal, posix, xxsubtype #106767

merged 1 commit into from Jul 18, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 15, 2023 •
edited by bedevere-bot

Use PyModule_AddObjectRef(...) instead of PyModule_AddObject(..., Py_NewRef(...)).

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 15, 2023
Closed
@rhettinger rhettinger removed their request for review July 15, 2023 20:33
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 17, 2023
Merged
@serhiy-storchaka serhiy-storchaka merged commit 7454923 into python:main Jul 18, 2023
24 checks passed
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.11

@serhiy-storchaka serhiy-storchaka deleted the pymodule-add4a branch July 18, 2023 06:00
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 18, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 18, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745492355b94d109e47827e5865846f25ae42d26 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] pythongh-86493: Fix possible leaks in modules initialization: …
d158e97 
…_curses_panel, _decimal, posix, xxsubtype (pythonGH-106767).

(cherry picked from commit 7454923)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106849 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Jul 18, 2023
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 18, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.12] gh-86493: Fix possible leaks in modules initialization: _curse…
970cb8e 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (#106849)

(cherry picked from commit 7454923)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] [3.12] pythongh-86493: Fix possible leaks in modules initializ…
b0b65c1 
…ation: _curses_panel, _decimal, posix, xxsubtype (pythonGH-106767) (pythonGH-106849)

(cherry picked from commit 7454923).
(cherry picked from commit 970cb8e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner
Copy link
Member

It's so hard to get PyInit code right :-( Thanks for the fix.

serhiy-storchaka added a commit that referenced this pull request Jul 18, 2023
@serhiy-storchaka
[3.11] gh-86493: Fix possible leaks in modules initialization: _curse…
3841af4 
…s_panel, _decimal, posix, xxsubtype (GH-106767) (GH-106849) (GH-106851)

(cherry picked from commit 7454923)
(cherry picked from commit 970cb8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @vstinner