Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: Argument Clinic: Modernise parse_special_symbol() #106837

Merged
merged 8 commits into from
Jul 17, 2023
Merged

gh-104683: Argument Clinic: Modernise parse_special_symbol() #106837

merged 8 commits into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. Annotate

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    230b85f View commit details
    Browse the repository at this point in the history

  2. Refactor: extract functions

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    98273d4 View commit details
    Browse the repository at this point in the history

  3. Fix mypy warnings

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6994d09 View commit details
    Browse the repository at this point in the history

  4. Remove parse_special_symbol()

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8e36b51 View commit details
    Browse the repository at this point in the history

  5. Pull in main

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b402b29 View commit details
    Browse the repository at this point in the history

  6. Address code review: exhaustive match

    @AlexWaygood @erlend-aasland
    AlexWaygood authored and erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    1a08f13 View commit details
    Browse the repository at this point in the history

  7. Address review

    @erlend-aasland
    erlend-aasland committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    deb05a2 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
    @erlend-aasland @AlexWaygood
    erlend-aasland and AlexWaygood committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b0ae589 View commit details
    Browse the repository at this point in the history