Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106751: Optimize _PolllikeSelector for many iteration case #106884

Merged
merged 8 commits into from Jul 20, 2023
Merged

gh-106751: Optimize _PolllikeSelector for many iteration case #106884

merged 8 commits into from Jul 20, 2023

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Jul 19, 2023 •
edited by bedevere-bot

Optimize the select and modify of the _PolllikeSelector in the same style as the other PRs from #106751

@corona10

@bedevere-bot bedevere-bot mentioned this pull request Jul 19, 2023
Closed
corona10
corona10 reviewed Jul 19, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
@corona10
Copy link
Member

corona10 commented Jul 19, 2023 •
edited

@eendebakpt Would you like to run the benchmark on the local environment?

@eendebakpt
Copy link
Contributor Author

@eendebakpt Would you like to run the benchmark on the local environment?

Local benchmark adapted from the issue:

original: 9.72887155600074
new: 8.924290647999442

corona10
corona10 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

corona10
corona10 reviewed Jul 19, 2023
View reviewed changes
Lib/selectors.py Outdated Show resolved Hide resolved
eendebakpt and others added 2 commits July 19, 2023 17:05
@eendebakpt @corona10
Update Lib/selectors.py
f60f887 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@eendebakpt
Merge branch 'main' into polllikeselector
fa72c2a
@corona10 corona10 changed the title gh-106751: Optimize _PolllikeSelector gh-106751: Optimize _PolllikeSelector for many iteration case Jul 20, 2023
@corona10 corona10 merged commit 832c37d into python:main Jul 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eendebakpt @corona10 @bedevere-bot