Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34100: Partially revert merge_consts_recursive() #10743

Merged
merged 2 commits into from Nov 27, 2018
Merged

bpo-34100: Partially revert merge_consts_recursive() #10743

merged 2 commits into from Nov 27, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 27, 2018

Partically revert commit c2e1607 to
fix a reference leak.

https://bugs.python.org/issue34100

Partically revert commit c2e1607 to
fix a reference leak.
@methane
Copy link
Member

methane commented Nov 27, 2018

I'd like to leave some comment like // Limitation: We don't merge frozenset for now.

@vstinner
Copy link
Member Author

I'd like to leave some comment like // Limitation: We don't merge frozenset for now.

I wrote a quick & dirty fix, just to repair the CI. I know that you will work hard to write a proper fix :-)

@vstinner vstinner merged commit 1005c84 into python:master Nov 27, 2018
@vstinner vstinner deleted the revert_merge_consts branch November 27, 2018 14:12
methane added a commit to methane/cpython that referenced this pull request Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants