Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-104584: Fix incorrect uoperands #107513

Merged
merged 3 commits into from Jul 31, 2023
Merged

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 31, 2023

There's currently an off-by-one error during trace construction that causes incorrect values to be loaded from the inline caches.

This fix results in a significant reduction in deoptimization events, and a dramatic improvement in our ability to stay on trace!

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 31, 2023
@brandtbucher brandtbucher self-assigned this Jul 31, 2023
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm surprised this never showed when I tested things. I guess it just caused excessive cache failures. :-(

@brandtbucher brandtbucher enabled auto-merge (squash) July 31, 2023 21:16
@brandtbucher brandtbucher merged commit 5e584eb into python:main Jul 31, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants