Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) #107599

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 3, 2023

The linked list of objects was a global variable, which broke isolation between interpreters, causing crashes. To solve this, we've moved the linked list to each interpreter.
(cherry picked from commit 58ef741)

Co-authored-by: Eric Snow ericsnowcurrently@gmail.com

…ters (pythongh-107567)

The linked list of objects was a global variable, which broke isolation between interpreters, causing crashes. To solve this, we've moved the linked list to each interpreter.
(cherry picked from commit 58ef741)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@Yhg1s Yhg1s merged commit 58af229 into python:3.12 Aug 3, 2023
24 checks passed
@miss-islington miss-islington deleted the backport-58ef741-3.12 branch August 3, 2023 22:18
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 4, 2023
@bedevere-bot
Copy link

GH-107648 is a backport of this pull request to the 3.12 branch.

Yhg1s pushed a commit that referenced this pull request Aug 5, 2023
… Under Isolated Subinterpreters (gh-107567) (#107599)" (#107648)

Revert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)"

This reverts commit 58af229.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Aug 7, 2023
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
…eters (#107751)

* Unrevert "[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters (gh-107567) (#107599)".

This reverts commit 6e4eec7 (gh-107648).

* Initialize each interpreter's refchain properly.

* Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants