Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105539: Emit ResourceWarning if sqlite3 database is not closed explicitly #108015

Merged
merged 12 commits into from
Aug 22, 2023
Merged

gh-105539: Emit ResourceWarning if sqlite3 database is not closed explicitly #108015

merged 12 commits into from
Aug 22, 2023

Commits on Aug 16, 2023

  1. pythongh-105539: Emit ResourceWarning if sqlite3 database is not clos… 

    …ed explicitly
    @erlend-aasland
    erlend-aasland committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4a8d209 View commit details
    Browse the repository at this point in the history

  2. Fix Sphinx warning

    @erlend-aasland
    erlend-aasland committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c00bdcf View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8075485 View commit details
    Browse the repository at this point in the history

  2. Add back test

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a12b7a4 View commit details
    Browse the repository at this point in the history

  3. Fix indent

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d102ea0 View commit details
    Browse the repository at this point in the history

  4. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c573f15 View commit details
    Browse the repository at this point in the history

  5. Address review: move finalizing check from the close helper to the fi… 

    …nalizer
    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8ebc8a7 View commit details
    Browse the repository at this point in the history

  6. Fix pointer deref and move exception guard

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b67a3c0 View commit details
    Browse the repository at this point in the history

  7. Slightly more informative error message

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    980d4d2 View commit details
    Browse the repository at this point in the history

  8. Only remove callbacks if there is a database to close

    @erlend-aasland
    erlend-aasland committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    03a034d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Pull in main

    @erlend-aasland
    erlend-aasland committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6f6cd82 View commit details
    Browse the repository at this point in the history

  2. Fix merge

    @erlend-aasland
    erlend-aasland committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    744bd1d View commit details
    Browse the repository at this point in the history