Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105481: opcode.h is no longer generated during the build #108080

Merged
merged 3 commits into from Aug 17, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 17, 2023

Python's operators don't change very often. This doesn't need to be auto-generated.

Makefile.pre.in Outdated Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, though I'm unsure of the benefit here. We now have two places where the list of NB_ constants occurs, once in opcode.h, once in _opcode.c, and they must be kept in sync manually.

@@ -36,6 +34,7 @@ extern "C" {
#define NB_INPLACE_TRUE_DIVIDE 24
#define NB_INPLACE_XOR 25

#define NB_OPARG_LAST 25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike marking the "last" of anything, you end up doing + 1 in various places. But I realize that it's a convention around opcode definitions and the like.

@iritkatriel
Copy link
Member Author

There are a number of lists/enumerations that need to exist in parallel python and C. I think to avoid the duplication in the code we should design something generic that spawns the #definitions in C and a function that builds the python dict to map the name to the number. Something like argument clinic, but for enumerations. I don't like having a special script for each case.

@iritkatriel iritkatriel merged commit 0b243c2 into python:main Aug 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants