Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-31177: Skip deleted attributes while calling reset_mock (GH-9302) #10842

Merged
merged 1 commit into from Dec 1, 2018
Merged

[3.6] bpo-31177: Skip deleted attributes while calling reset_mock (GH-9302) #10842

merged 1 commit into from Dec 1, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 1, 2018 •
edited by bedevere-bot

(cherry picked from commit edeca92)

Co-authored-by: Xtreak tirkarthi@users.noreply.github.com

https://bugs.python.org/issue31177

@tirkarthi @miss-islington
bpo-31177: Skip deleted attributes while calling reset_mock (pythonGH…
a2e4ea8 
…-9302)

(cherry picked from commit edeca92)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 1, 2018
Merged
vstinner
vstinner approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@tirkarthi and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c0566e0 into python:3.6 Dec 1, 2018
@miss-islington miss-islington deleted the backport-edeca92-3.6 branch December 1, 2018 10:16
@miss-islington
Copy link
Contributor Author

@tirkarthi and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @tirkarthi