Fix a code snippet typo in asyncio docs #108427
Conversation
Dumeng
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
hugovk
added
needs backport to 3.11
|
Thanks @Dumeng for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @Dumeng for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 7f31676) Co-authored-by: A <5249513+Dumeng@users.noreply.github.com>
|
GH-111244 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 7f31676) Co-authored-by: A <5249513+Dumeng@users.noreply.github.com>
|
GH-111245 is a backport of this pull request to the 3.12 branch. |
|
Whoa. Did anyone actually review this? The example was part of an explanation of what |
|
I'm rather late to the party here, but I don't agree with this change. The point of the original example was that, in the absence of cancellation, And as I was typing this, Guido posted his comment as well. I'll start the revert. |
This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: python#108427 (comment)
This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: #108427 (comment)
…ythonGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Co-authored-by: Zachary Ware <zach@python.org> Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
…ythonGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Co-authored-by: Zachary Ware <zach@python.org> Ref: https://github.com/python/cpython/pull/108427GH-issuecomment-1777525740
|
Sorry for the inappropriate change. I, maybe the reviewers also, thought the snippet is for explaining the statement above. I didn't realize it's for explaining the equivalence. Maybe we can add a statement before the snippet to explicitly point out the equivalence. |
|
I opened gh-111274 for discussing whether there should actually be a change here. |
…H-111271) (GH-111272) Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Ref: #108427 (comment) Co-authored-by: Zachary Ware <zach@python.org>
…H-111271) (GH-111273) Revert "Fix a code snippet typo in asyncio docs (GH-108427)" (GH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) (cherry picked from commit c7d68f9) Ref: #108427 (comment) Co-authored-by: Zachary Ware <zach@python.org>
…honGH-111271) This reverts commit 7f31676. The change resulted in a tautology and should not have been made. There may be an opportunity for additional clarity in this section, but this change wasn't it :) Ref: python#108427 (comment)
Fix a code snippet typo in asyncio-task docs. The coroutine in the sample code should be protected by the
shield.📚 Documentation preview 📚: https://cpython-previews--108427.org.readthedocs.build/