-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106922: Fix error location for constructs with spaces and parentheses #108959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
changed the title
gh-104676: Fix error location for constructs with spaces and parentheses
gh-106922: Fix error location for constructs with spaces and parentheses
Sep 5, 2023
pablogsal
force-pushed
the
gh-106922
branch
2 times, most recently
from
September 5, 2023 19:56
86ed570
to
2f42728
Compare
pablogsal
added
needs backport to 3.10
only security fixes
needs backport to 3.11
only security fixes
needs backport to 3.12
bug and security fixes
and removed
needs backport to 3.10
only security fixes
labels
Sep 5, 2023
…rentheses Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2023
…rentheses (pythonGH-108959) (cherry picked from commit 6275c67) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
GH-109147 is a backport of this pull request to the 3.12 branch. |
GH-109148 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 8, 2023
…rentheses (pythonGH-108959) (cherry picked from commit 6275c67) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Sep 8, 2023
pablogsal
added a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Galindo pablogsal@gmail.com