gh-88943: Improve syntax error for non-ASCII character that follows a numerical literal #109081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lows a numerical literal It now points on the invalid non-ASCII character, not on the valid numerical literal.
serhiy-storchaka
added
type-bug
serhiy-storchaka
requested review from
pablogsal and
lysnikolaou
as code owners
pablogsal
approved these changes
Sep 7, 2023
lysnikolaou
approved these changes
Sep 7, 2023
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
serhiy-storchaka
deleted the
syntax-error-invalid-nonascii-after-numeric-literal
branch
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…lows a numerical literal (pythonGH-109081) It now points on the invalid non-ASCII character, not on the valid numerical literal. (cherry picked from commit b2729e9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-109090 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 7, 2023
…hat follows a numerical literal (pythonGH-109081) It now points on the invalid non-ASCII character, not on the valid numerical literal.. (cherry picked from commit b2729e9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-109091 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 7, 2023
Yhg1s
pushed a commit
that referenced
this pull request
Oct 2, 2023
…llows a numerical literal (GH-109081) (#109090) gh-88943: Improve syntax error for non-ASCII character that follows a numerical literal (GH-109081) It now points on the invalid non-ASCII character, not on the valid numerical literal. (cherry picked from commit b2729e9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now points on the invalid non-ASCII character, not on the valid numerical literal.